...

1. Brian Lowe
2. Benjamin Kampe 
3. Georgy Litvinov 
4. Michel Héon 
5. William Welling 
6. Huda Khan 
7. Benjamin Gross 
8. Ralph O'Flinn  
9. Don Elsborg 

Agenda

1. Announcements / updates
2. Mailing list / Slack discussion
3. RC1 issues to resolve:

4. Jira
   server LYRASIS JIRA jqlQuery project = VIVO AND fixVersion = v1.12 AND priority = Blocker AND (status = Open OR status = "In Review" OR status = "In Progress" ) serverId c815ca92-fd23-34c2-8fe3-956808caf8c5

5.  Testing / results: Release Testing - 1.12.0
6. VIVO WCAG 2 A/AA  accessibility audit results from Deque
7. Updates on Data Ingest Task Force discussions
8. Prioritizing and planning post-1.12 development
   1. https://docs.google.com/spreadsheets/d/103P9P4v6yUBSb5BnVaK40NoGx1fIYyL8uaHKUubZWbE/edit?usp=sharing

...

Draft notes on Google Drive

1. Were hoping for release on Friday, but additional issues came up.
1. Thanks to Georgy and Benjamin K for effort resolving issues
2. Lingering issues, might still be a couple blockers but should be resolved by this week
3. VIVO-1994- Behavior of manage publications functionality backwards when operating in French. 
1. Text is misleading. Text says ‘display the conferences’ but the functionality actually is for ‘hiding’ the selected publications.
4. VIVO-1993- Publication count shows for sparkline, but no graph
1. Does not seem to be consistent. 
2. Seems to affect newly created persons, but not older
3. Brian - there was a previous fix for the google sparkline location 
4. For reference: https://jira.lyrasis.org/browse/VIVO-1950
5. Benjamin G - would be helpful if we could see if there is any error being thrown by the google viz library or if it is failing silently. 
5. VIVO-1992- UMLS search not working
1. Legacy issue for setting this up: https://jira.lyrasis.org/browse/VIVO-1534
2. Hopefully the search is still working… but we don’t know anybody actually being able to set it up and use it
3. Brian - in the custom form generator for this page there is a list of the services. We could add a property to runtime.properties to turn UMLS off so it doesn’t appear if it isn’t set up correctly. 
4. Benjamin - can we actually set up the username and password setup in runtime.properties instead of just having a flag for the generator template?
5. Brian - that’s actually more difficult than it would seem since the UMLS doesn’t use the context. 
6. Don - We are using MeSH terms pulled out of Elements.
7. Leaning toward middle option where we add option to hide the service (and issue) but not actually fix the issue.
6. https://jira.lyrasis.org/browse/VIVO-1991
1. Security issue in past couple versions of VIVO
2. Difference between how md5 and argon hashes work
3. Hash could be guessed in past 
4. A little tricky to test since smtp server needs to be set up
5. Brian can set up with gmail and test 
6. Georgy had set up a postfix server locally before (see https://gist.github.com/haccks/7ec2fe500332a6d23ee68d1c1a2279d5) 
7. https://jira.lyrasis.org/browse/VIVO-1990 
8. https://jira.lyrasis.org/browse/VIVO-1989
1. Brian discovered while testing other issues
2. End up with a redirect issue if you aren’t running VIVO at root context
3. Should be a simple test
4. Okay for a single review and merge 
5. Benjamin G will test
9. https://jira.lyrasis.org/browse/VIVO-1988
1. Unfortunately a little thornier than expected.
2. We likely want to retain the functionality to delete label in ‘all languages’ 
3. But it should probably be documented.
4. No loud objections and one thumbs up… will be pushed to 1.13
10. https://jira.lyrasis.org/browse/VIVO-1987 
1. Brian has been unable to reproduce
2. Georgy - it always returns the first added language 
3. Not hard-coded to English
4. If Brian set accept-language header in linked data request or via the dropdown, then he seemed to get the results he expected 
5. We need to find specific steps to reproduce bug otherwise not a blocker
11. https://jira.lyrasis.org/browse/VIVO-1986
1. Has approval
2. Needs some committer attention 
3. Benjamin G will test
12. https://jira.lyrasis.org/browse/VIVO-1985
1. Occured when you had multiple fallback languages but it was inconsistent between what was shown in view mode and what it was trying to edit.
2. We probably want to reconsider a better priority mechanism for fallback languages.
3. Can anybody take a look…..? *crickets*
13. https://jira.lyrasis.org/browse/VIVO-1984 
1. Brian could not reproduce
2. Michel will retry to confirm
14. https://jira.lyrasis.org/browse/VIVO-1983
1. We talked a lot about this last week.
2. Led to same error as 1985.
3. PR makes behavior consistent with other forms
4. Will just see label for current language now (or insert new label) unless you’ve ingested data where there are multiple labels in a single language 
5. Should be a fairly quick one to test
15. Michel has a new ticket
1. Installer - condition to adding a new language is all source code must be in installation
2. Cannot only download via Maven, must clone repo 
3. It would be nice if we had an option to clone all repositories easily. 
4. Brian - the wrinkle is the behavior for VIVO/Vitro doesn’t match what the language repos does. 
5. Michel will create a new issue to describe issue 
16. Georgy - will there be another meeting Friday?
1. Brian - if committers meet tomorrow we should hopefully rally and get things merged 
2. If there’s still more to do a Friday meeting might be necessary.
3. Stay tuned!