Versions Compared

Old Version 1

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version Current

changes.mady.by.user Ben Bosman

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • (BEFORE MEETING IN #dev-sprint) Developer Stand Up - Developers give brief updates on their effort (or their team's effort).

    • Update/see "Current Work" section below based on your status. Please feel free to update prior to meeting.
    • Please highlight any new work (needing reviews/testing), any blockers (for you), and any discussion topics you may have.
  • (30 25 mins) General Discussion Topics
    1. (10 15 mins) Followup Follow-up to Submission form conceptual design: 
      1. Last week we agreed that Submission Process should ONLY touch WorkspaceItem and WorkflowItem (per it's initial design).  Therefore, we must fix/refactor any code in the Submission Process which bypasses those objects/endpoints to read from or update Item objects/endpoints. 
      2. Updates since last week:
        1. Atmire is working on a plan to address the improper behavior in
        One known example of that improper behavior is
        1. the code merged in PR#541
        .  One possible way to fix that behavior is documented in 
        1.  based on the issue ticket https://github.com/DSpace/dspace-angular/issues/818
      3. Questions for the team:
        1. Do we have (rough) estimates of the effort it would take to fix the code from PR#541 to align with the agreed upon behavior?
        2. Are there any quick/small workarounds that could be applied immediately while that behavior is fixed?
        3. If no quick fix or solution can be found, we may need to temporarily revert this work & schedule it for fixing/refactoring in 7.0beta5.
      (5 mins) Followup to Security issues on the Process REST API
        1. Giuseppe provided a "quick fix" solution for his (previously blocked) Controlled Vocab PR: https://github.com/DSpace/dspace-angular/pull/751
        2. The two bugs caused by PR#541 are being fixed:
      2. We agree that some CLI flags should never be usable via the REST API (e.g. `--eperson`). We should find a way to either disable these flags automatically via the REST API, or perhaps a way to configure (per script) which flags are "CLI-only".
        1. Currently both the "--eperson" (in 
          1. https://github.com/DSpace/dspace-angular/issues/816 (in progress)
          1. https://github.com/DSpace/
          DSpace
          1. dspace-angular/issues/
          2822 and 
          1. 817 → Has a PR: https://github.com/DSpace/
          DSpace
          1. dspace-angular/pull/
          2820) and "--file" (in 
          1. 830
    2. (10 mins) Scripts & Processes Output REST PR: https://github.com/DSpace/DSpace/issues/2821) flags seem to be the first ones that fit into this issue.
    3. Kevin Van de Velde (Atmire) is currently looking at a solution & will report back to us on a possible fix.  Any updates to share this week?
    4. Additional topics welcome. Please add by Tues, Aug 4.
    5. /pull/2905
      1. Tim has performance/scalability concerns regarding the Hibernate code/configuration added here to store Process output logs in the database. 
      2. Should we rethink this approach?  Or is there a way to implement with current Hibernate settings?
  • (35 (30 mins) Planning for next week
    • Tim is on holiday from Aug 10-18. Do we want to cancel next week's meeting on Thursday, Aug 13? (i.e. just give updates via Slack)
    • Review of our Beta 4 Project Board

...

...