Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. 4-space indents for Java, and 2-space indents for XML. NO TABS ALLOWED.
    1.  Only exception is throws clause, which should be indented 8 spaces if on a new line
  2. K&R style braces required. Braces are also required on all blocks.

    Code Block
    if (code) {
      // code
    } else {
      // code
    }


  3. Do not use wildcard imports (e.g. import java.util.*). Duplicated or unused imports are also not allowed.
  4. Write Javadocs for public methods and classes. Keep it short and to the point.
    1. Javadoc @author tags are optional, but should refer to an individual's name or handle (e.g. GitHub username) when included
  5. Maximum length of lines is 120 characters.characters (except for long URLs, packages or imports)

  6. No trailing spaces allowed (except in comments)
  7. Tokens should be surrounded by whitespace, e.g. http://checkstyle.sourceforge.net/config_whitespace.html#WhitespaceAround

    Code Block
    // This is not valid -- needs whitespace around tokens
    String []={"one","two","three"}
    
    
    // This is valid -- whitespace around all tokens
    String [] = { "one", "two", "three" }


  8. Each line of code can only include one statement.  This also means each variable declaration must be on its own line, e.g.

    Code Block
    // This is not valid -- three variables declared on one line
    String first = "", second = "", third = "";
    
    
    // This is valid, each statement is on its own line
    String first = "";
    String second = "";
    String third = "";


  9. No empty "catch" blocks in try/catch.  At least include a comment as to why the catch is empty, e.g. 

    Code Block
    try {
      // some code ..
    } catch (Exception e) {
      // ignore, this exception is not important
    }


  10. All "switch" statements must include a "defaut" clause.  Also, each clause in a switch must include a "break", "return", "throw" or "continue" (no fall throughs allowed), e.g. 

    Code Block
    // This is not valid -- doesn't include a "default" and also is missing a "break" in first "case"
    switch (myVal) {
      case "one":
         // do something
      case "two":
         //do something else
         break;
    }
    
    
    // This *is* valid.  Has all necessary breaks, and includes a "default"
    switch (myVal) {
      case "one":
         // do something
         break;
      case "two":
         //do something else
         break;
      default:
         // do nothing
         break;
    }


  11. Each source file must contain the required license header, e.g.

    Code Block
    /**
     * The contents of this file are subject to the license and copyright
     * detailed in the LICENSE and NOTICE files at the root of the source
     * tree and available online at
     *
     * http://www.dspace.org/license/
     */


...