Versions Compared

Old Version 39

changes.mady.by.user Tim Donohue

Saved on

compared with

New Version 40

changes.mady.by.user Tim Donohue

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Info
titleCode Review Timeframe

The timeframe of a code review will vary, based on how much time the Committers have. Smaller patches may be reviewed within days, while larger patches/features may take many weeks to do a full review. All Committers are volunteers and only have a small amount of time to provide to the project in a given week. We will make every effort to get back to you with feedback within a few weeks. But, if you haven't heard anything, feel free to ask!

Note
titleWhat are you reviewing for?

When we review your code, we are mostly ensuring it generally follows our Code Contribution Standards. However, there are a few other things we generally check for:

  • The code is stable and has no stability or security concerns
  • The code is properly using existing APIs, etc.
  • The code is not too specific to one institution's local policies or workflows. (I.e. we will review the code to ensure it looks to be generally useful to most institutions, or configurable enough such that others can change it to match their own local policies/workflows)

3. Reworking Code (if necessary) & Next Steps

...