How to connect: https://psu.zoom.us/j/613720745 (link will launch Zoom client – if you do not have Zoom, expand the instructions below)
Meeting ID: 613 720 745
+1 646 876 9923 (US Toll)
+1 669 900 6833 (US Toll)
+1 408 638 0968 (US Toll)
International numbers available: https://psu.zoom.us/zoomconference?m=UZ_PRwQ56TNX1pDIsdDInAu8XPVqzlX3
Meeting ID: 613 720 745
126.96.36.199 (US West)
188.8.131.52 (US East)
184.108.40.206 (Hong Kong)
Time: 9:00am PDT / Noon EDT
Moderator: Jim Coble
Notetaker: James R. Griffin III
Roll call by timezone per following order - ensure notetaker is present (moderator)
folks outside North and South America
folks who were missed or who dialed in during roll call
- Remind everyone to sign in on agenda.
- Welcome all newcomers!
- Agenda (moderator)
- Call for new agenda items (moderator)
- Turn off Hyrax Batch ingest by default? (Tom Johnson)
- Replace Hyrax::Callbacks with Dry::Events? (Tom Johnson)
- Straw PR for discussion: https://github.com/samvera/hyrax/pull/4132
- See especially: https://github.com/samvera/hyrax/pull/4132/files#diff-e37293a3703317fdbe7afc82c8354728R4-R45
- Core Components WG chair volunteers?
- Hyrax Speed Test (i.e. benchmarks we can share and compare) (Andrew Myers)
- Samvera Docs WG needs love (i.e. ideas + cycles) (Andrew Myers)
- Moderator & notetaker for next time
- After call, this week's notetaker should create the agenda for the next call:
Open template agenda titled "Samvera Tech Call 2019-xx-xx"
- Click on ... in the top right corner, and select copy.
- Popup will open for location. It should contain:
- Space: Samvera
- Parent page: 2019
- Select copy. New page should be created.
- Modify the title to remove "copy of", update it with the next date, add moderator, notetaker, and any carry-over agenda info. Click Publish.
- PR Review
- Review issues:
- PR review coordinator for next time:
Hyrax Batch Ingest
There is a pull request (4129), which was merged yesterday; this defaults to disabling batch ingest features for Hyrax 3.0.0
Batch ingest has some conflicts if there is customized metadata
It's been on the roadmap to address improving aspects of this feature (or, perhaps, even replacing it)
As this is a feature flipper default, one can still enable it, it just must be done so explicitly
U. Cincinnati noted that they are satisfied with the feature
Hyrax::Callbacks and Dry::Events
There is a pull request (4142) for which might be in a reviewable state (the test failures may be unrelated)
Since 2015, Hyrax has had its own custom pub/sub callback system
Tom Johnson has been looking to shift this towards a more consistent approach
Currently, callbacks are blocks with a name, with one listener per event topic
The subscriber registry is mutable but not thread-safe (different processes can modify this and introduce conflicts)
Dry::Events provides an alternative implementation for this functionality, with the added benefit of building upon the labors of the dry-rb community
Existing callbacks will need to be deprecated from the registration side
Adopters will need to adjust the dry-events configuration
Does this relate to Valkyrie?
This is mostly orthogonal to Valkyrie, but it was discovered while Tom has been addressing Valkyrie-related work
How are events currently being used?
Events are exclusively called from the Actor stack
Callback names are like "after_object_created"
They are used to trigger jobs for background processing
WGBH supports this change in implementation
Drew Myers noted that Hyrax::Callbacks was not originally written with the pub/sub pattern in mind
To what extent is this a new paradigm?
Tom: Listeners are registered on an application-level basis, with callbacks being invoked explicitly
Wants to ensure that any concerns regarding the new paradigm is captured from community contributors
Chris Colvard: Nested indexing also may be registering methods with Hyrax::Callbacks (outside of Hyrax)
Chris will review this elsewhere and confirm that this is the case
Core Components Working Group Chair Volunteers
Call for volunteers to serve as the chair for the next phase of the Working Group
This WG can no longer be a viable Working Group without a chair
With a chair, this WG will run for a full year, with the hope that new charter will be drafted at the end
What is the deadline for a new chair?
Looking to draw the old group to a close in three weeks
Hyrax Speed Test
During Connect, attendees were sharing benchmarks/speed tests within production-like environments to debug infrastructures within each institution
This also provided a better expectation as to what to expect
At the end of these discussions, Drew volunteered to serve as a coder, but wanted to stop shy of forming a formal Working Group
Calling for volunteers with Hyrax installations available in staging environments (a vanilla installation with an empty repository is strongly preferred)
Drew will look to follow this call with an e-mail to the samvera-tech Google Group
Tom: There is another line of performance and observability-related work which is related
Rebuilding Nurax in a containerized environment, with the aim of integrating Honeycomb into this Docker build
It might be best to assess what others are using in their productions environments for analyzing performance troubles for Hyrax in production
Samvera Documentation Working Group
Status of the WG is that there has been little progress recently in working to progress with improving documentation
Drew is looking to call for a renewed effort and reviving the Working Group
The aim should also be to attempt to have this as a standing Working Group (as documentation maintenance should be ongoing)
Some of the proposed documentation improvements may require minimal maintenance
Should the existing Working Group be canceled, with a new WG formed?
It was noted that the charter for the current WG is long expired
Should this be an Interest Group which exists indefinitely, or remain a Working Group with deliverables and a sunset date?
Drew: Started with the preference for a Working Group, but this requires volunteers
Trey: Strong proponent of the requirements of Working Groups, if they are not active, they should be removed from the list of existing WGs
If there aren't the resources, then perhaps the WG should be run later
Recommends rechartering, and accepting that there simply might not be the resources for renewal
Tom: Chartering process does not have to be heavy-weight, but it does have the benefit of forcing a reconsideration with each new renewal
Drew will issue a CfP for the new Working Group
Next Scheduled Call:
Moderator: Drew Myers
Notetaker: Jason Corum
Meeting adjourned at 09:32 PDT/12:32 EDT
Hyrax Pull Request Review
Updated with some changes
There is a long history
Testing with Rails 6
Chris does not have the availability to continue working on this
Will close this for now
Date issues in the Safari browser
Should we using `var` as opposed to `let` in .es6 files?
Proposed changes affect all browsers as opposed to targeting just Safari (this might not be an issue)
James left a comment regarding the `var`/`let` usage
This was approved, but there are still legitimately failing tests
There is still work to be done to complete this pull request
Methods for attaching file_set to a Work
Lynette needs to still return to this
New query for the metadata adapter
There is still work going on for this
There were changes requested
Still has failing tests
This just has one build failing
Links to 4057
There are in-depth conversations
Best to leave Tom and Lynette finalize the work on this
Has legitimately failing tests
There are two failing tests for the changes introduced here
Blacklight::SearchState might be a service class
Perhaps the tests themselves need to be updated?
Chris provided a comment addressing this
Questions regarding #extract_subjects, but otherwise looks like a good improvement
Chris will review this further
Session concluded at 13:02 EDT